Module review findings

Every enhancement and every import leaves behind a review of the code it touched: what it checked, what it found, and — for an enhancement — whether the result actually covers what you asked for. This page covers reading those reviews afterwards, from the module’s own page. It doesn’t cover the enhancement discuss screen or the import dialog themselves; see the two pages above for that.

Opening the Review tab

Open the Modules Library and click a module’s name to open its own page, then click the Review tab. If any review has open findings, the tab carries a count badge — N to fix — built from the same findings the tab lists below, so the two can never disagree.

A module that has never been enhanced or imported has nothing to show here yet: the tab reads No review has been recorded for this module yet.

Picking which review you’re looking at

A module can carry more than one review — one per enhancement, one per import — so a row of chips across the top lets you switch between them, newest first:

v_N_ · enhancement review — the review that ran before enhancement version N was implemented.
v_N_ · import analysis — the review that ran when version N was imported as a ZIP.
current enhancement · review — an enhancement’s review is ready but you haven’t moved past its discuss screen yet (see enhancing a module). It’s the same review that screen showed you; once you finish the enhancement, this chip is replaced by the version it produced.

Requirements coverage

For an enhancement review, a Requirements coverage card lists every requirement the review checked the result against, one row per requirement, with its status — MET, PARTIAL, MISSING, or ? when the review couldn’t tell — and, where the review could point to it, a Where column naming the file (and sometimes line) that satisfies it. A chip in the card’s header summarizes the row: All N met in green when every row does, M of N met in amber otherwise.

An import has no requirement to check against, so its review never has a coverage table — and occasionally an enhancement review’s write-up doesn’t resolve into one either. Either way the card reads This review did not produce a requirements table instead of an empty table.

Findings: open, resolved, and notes

Below coverage (or alone, for an import), the review’s findings are split into up to three groups:

To fix — findings still open: not yet superseded by a later version. Each shows a severity badge — ERROR, WARN, or NOTE — the file it’s about, if any, and the finding’s text.
Resolved in v_N_ — findings that were open when this review ran, but a later version has since shipped. The label marks the review as superseded by v_N_, not that each finding was individually re-checked and confirmed fixed.
Notes — informational (NOTE-severity) findings, plus any free-form notes the review recorded that aren’t tied to a specific finding at all (an import’s noted coding conventions, for example, or an enhancement review flagging a sudo() call as intentional and low-risk).

Fixing an open finding

Next to each finding in To fix, a Fix with Enhance button starts a new enhancement with the finding’s text — and file, if it has one — already filled in as the description, so you don’t have to retype what the review already told you. You can still edit that description before starting the enhancement, or ignore the button and describe the fix your own way instead; it’s a shortcut, not the only path.

Resolved and note-severity findings don’t get this button — there’s nothing open left to enhance away.

How findings affect the module’s status

Only open, ERROR-severity findings on the module’s currently shipped version count against its status pill: they’re what turns it Needs attention, alongside a matching line in its verification popover (N open review findings). Warnings and notes never do, even while they sit in the same To fix list waiting to be addressed.

Because of this, the Review tab’s N to fix badge can read differently from the status pill: the badge counts every open finding across every recorded review — including one still in an active enhancement’s discuss screen, before that enhancement has shipped anything — while the pill only ever reflects the version you’d actually get today.